Y
Hacker News
new
|
ask
|
show
|
jobs
Show HN: Example implementation of Mozilla's persona and Go server
(
github.com
)
38 points
by
sauerbraten
4773 days ago
2 comments
trebor
4773 days ago
I didn't realize this, but this is a Persona client library not a Persona server. Not sure why I confused them, but figure it was worth mentioning.
link
sauerbraten
4773 days ago
Yeah, I worded it differently when I submitted it to /r/golang: Example of using Mozilla's persona with Go
link
krf
4773 days ago
I'm new to Go but shouldn't the defer rawResp.Body.Close() be done after the error checking. If there is an error wouldn't rawResp be nil ?
link
sauerbraten
4773 days ago
You're right. Fixed it, thanks!
link
realrocker
4773 days ago
Yup. It should be closed or it will probably leak memory in a few hours.
link
sauerbraten
4773 days ago
Not really. Memory would only be leaked if there really was an error and rawResp was still nil. Since this usually doesn't happen (at least it never happened to me), you probably wouldn't even have noticed this bug.
link