Note the diff does not show "print 'did you see this coming?'" as a change - yet once merged python will run it with no problems.
Interestingly, if you hit expand at the bottom left, you will see "print 'did you see this coming?'" in both the master and the PR version... which is not the case.
Remember to review PRs in git, not GitHub - especially if you're working on sensitive software!
File on master: https://github.com/jacksingleton/cr-newline-diff-test/blob/m... File in pull request: https://github.com/jacksingleton/cr-newline-diff-test/blob/v...
Note the diff does not show "print 'did you see this coming?'" as a change - yet once merged python will run it with no problems.
Interestingly, if you hit expand at the bottom left, you will see "print 'did you see this coming?'" in both the master and the PR version... which is not the case.
Remember to review PRs in git, not GitHub - especially if you're working on sensitive software!